summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Junio C Hamano <gitster@pobox.com>2019-02-06 22:05:24 -0800
committerLibravatar Junio C Hamano <gitster@pobox.com>2019-02-06 22:05:24 -0800
commitd8d62e61353c7e34006cc5714f07f507256612df (patch)
tree30e38966f1540e10574e0242431dbfce4c385ff7
parentMerge branch 'lt/date-human' (diff)
parenttest-lint: only use only sed [-n] [-e command] [-f command_file] (diff)
downloadtgif-d8d62e61353c7e34006cc5714f07f507256612df.tar.xz
Merge branch 'tb/test-lint-sed-options'
The test lint learned to catch non-portable "sed" options. * tb/test-lint-sed-options: test-lint: only use only sed [-n] [-e command] [-f command_file]
-rwxr-xr-xt/check-non-portable-shell.pl2
1 files changed, 1 insertions, 1 deletions
diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl
index 8037eef777..166d64d4a2 100755
--- a/t/check-non-portable-shell.pl
+++ b/t/check-non-portable-shell.pl
@@ -36,7 +36,7 @@ while (<>) {
}
/\bcp\s+-a/ and err 'cp -a is not portable';
- /\bsed\s+-i/ and err 'sed -i is not portable';
+ /\bsed\s+-[^efn]\s+/ and err 'sed option not portable (use only -n, -e, -f)';
/\becho\s+-[neE]/ and err 'echo with option is not portable (use printf)';
/^\s*declare\s+/ and err 'arrays/declare not portable';
/^\s*[^#]\s*which\s/ and err 'which is not portable (use type)';