diff options
| author |  Shawn O. Pearce <spearce@spearce.org> | 2007-09-18 04:54:51 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2007-09-19 03:22:31 -0700 |
| commit | d8b3a2bf189a9e7fea76454157b77fa71c9abc05 (patch) | |
| tree | 66808d008034726076279f1ba8dae7ec95c2fad1 | |
| parent | builtin-fetch: Don't segfault on "fetch +foo" (diff) | |
| download | tgif-d8b3a2bf189a9e7fea76454157b77fa71c9abc05.tar.xz | |
Don't attempt to merge non-existant remotes in t5515
This was actually reverted in 756373da by Junio. We no longer
support merging the right hand side of a fetchspec in a branch's
branch.$name.merge configuration setting as we interpret these
names as being only those published by the remote we are going to
fetch from.
The older shell based implementation of git-fetch did not report an
error when branch.$name.merge was referencing a branch that does
not exist on the remote and we are running `git fetch` for the
current branch. The new builtin-fetch does notice this failure
and aborts the fetch, thus breaking the tests.
Junio and I kicked it around on #git earlier today and decided that
the best approach here is to error out and tell the user that their
configuration is wrong, as this is likely more user friendly than
silently ignoring the user's request. Since the new builtin-fetch
is already issuing the error there is no code change required, we
just need to remove the bad configuration from our test.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
| -rwxr-xr-x | t/t5515-fetch-merge-logic.sh | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/t/t5515-fetch-merge-logic.sh b/t/t5515-fetch-merge-logic.sh index 6c9cc67508..31c1081617 100755 --- a/t/t5515-fetch-merge-logic.sh +++ b/t/t5515-fetch-merge-logic.sh @@ -84,8 +84,7 @@ test_expect_success setup ' git config branch.br-$remote-merge.merge refs/heads/three && git config branch.br-$remote-octopus.remote $remote && git config branch.br-$remote-octopus.merge refs/heads/one && - git config --add branch.br-$remote-octopus.merge two && - git config --add branch.br-$remote-octopus.merge remotes/rem/three + git config --add branch.br-$remote-octopus.merge two done ' |