diff options
author | Junio C Hamano <gitster@pobox.com> | 2021-10-12 13:51:30 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-10-12 13:51:30 -0700 |
commit | d46f95a2bd265b195e6a9e88896d200b6b3a203f (patch) | |
tree | 5b57e9cbec7881eb49fe18f057264b5e3906cff8 | |
parent | Merge branch 'ab/mailmap-leakfix' into maint (diff) | |
parent | remote: avoid -Wunused-but-set-variable in gcc with -DNDEBUG (diff) | |
download | tgif-d46f95a2bd265b195e6a9e88896d200b6b3a203f.tar.xz |
Merge branch 'cb/remote-ndebug-fix' into maint
Build fix.
* cb/remote-ndebug-fix:
remote: avoid -Wunused-but-set-variable in gcc with -DNDEBUG
-rw-r--r-- | remote.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -135,7 +135,7 @@ static inline void init_remotes_hash(void) static struct remote *make_remote(const char *name, int len) { - struct remote *ret, *replaced; + struct remote *ret; struct remotes_hash_key lookup; struct hashmap_entry lookup_entry, *e; @@ -162,8 +162,8 @@ static struct remote *make_remote(const char *name, int len) remotes[remotes_nr++] = ret; hashmap_entry_init(&ret->ent, lookup_entry.hash); - replaced = hashmap_put_entry(&remotes_hash, ret, ent); - assert(replaced == NULL); /* no previous entry overwritten */ + if (hashmap_put_entry(&remotes_hash, ret, ent)) + BUG("hashmap_put overwrote entry after hashmap_get returned NULL"); return ret; } |