diff options
| author |  Elia Pinto <gitter.spiros@gmail.com> | 2016-01-04 10:10:49 +0100 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2016-01-04 13:45:16 -0800 |
| commit | c723e50d413882c5196e823312f2743a96d7d8c3 (patch) | |
| tree | f605c88e8309e93fcd0654f4a1d23185b911965e | |
| parent | t/t5570-git-daemon.sh: use the $( ... ) construct for command substitution (diff) | |
| download | tgif-c723e50d413882c5196e823312f2743a96d7d8c3.tar.xz | |
t/t5601-clone.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t5601-clone.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh index 9b34f3c615..61dc4ce125 100755 --- a/t/t5601-clone.sh +++ b/t/t5601-clone.sh @@ -221,7 +221,7 @@ test_expect_success 'clone separate gitdir' ' ' test_expect_success 'clone separate gitdir: output' ' - echo "gitdir: `pwd`/realgitdir" >expected && + echo "gitdir: $(pwd)/realgitdir" >expected && test_cmp expected dst/.git ' |