diff options
| author |  Tim Henigan <tim.henigan@gmail.com> | 2012-03-14 12:38:03 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2012-03-14 15:20:21 -0700 |
| commit | c5770f79068fb1317c1fd19da7e7bfcc075132f3 (patch) | |
| tree | a2f6fcd8641ce61a32a4531141777a53996ffb1d | |
| parent | contrib/diffall: comment actual reason for 'cdup' (diff) | |
| download | tgif-c5770f79068fb1317c1fd19da7e7bfcc075132f3.tar.xz | |
contrib/diffall: create tmp dirs without mktemp
mktemp is not available on all platforms. Instead of littering the code
with a work-around, this commit replaces mktemp with a one-line Perl
script.
Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | contrib/diffall/git-diffall | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/contrib/diffall/git-diffall b/contrib/diffall/git-diffall index d706a6dee3..443f646a77 100755 --- a/contrib/diffall/git-diffall +++ b/contrib/diffall/git-diffall @@ -45,13 +45,10 @@ cd "$cdup" || { exit 1 } -# mktemp is not available on all platforms (missing from msysgit) -# Use a hard-coded tmp dir if it is not available -tmp="$(mktemp -d -t tmp.XXXXXX 2>/dev/null)" || { - tmp=/tmp/git-diffall-tmp.$$ - mkdir "$tmp" || exit 1 -} - +# set up temp dir +tmp=$(perl -e 'use File::Temp qw(tempdir); + $t=tempdir("/tmp/git-diffall.XXXXX") or exit(1); + print $t') || exit 1 trap 'rm -rf "$tmp" 2>/dev/null' EXIT left= |