diff options
author | Junio C Hamano <gitster@pobox.com> | 2018-06-01 11:33:19 +0900 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2018-06-01 11:46:07 +0900 |
commit | c3072c6e4db9130d0920bc8034f197624874de3d (patch) | |
tree | c10134658e193a3b684326d3189f9ba7c91e6eac | |
parent | submodule: convert push_unpushed_submodules to take a struct refspec (diff) | |
download | tgif-c3072c6e4db9130d0920bc8034f197624874de3d.tar.xz |
refspec-api: avoid uninitialized field in refspec item
When parse_refspec() function was created at 3eec3700 ("refspec:
factor out parsing a single refspec", 2018-05-16) to take a caller
supplied piece of memory to fill parsed refspec_item, it forgot that
a refspec without colon must set item->dst to NULL to let the users
of refspec know that the result of the fetch does not get stored in
an ref on our side.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r-- | refspec.c | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -48,6 +48,8 @@ static int parse_refspec(struct refspec_item *item, const char *refspec, int fet size_t rlen = strlen(++rhs); is_glob = (1 <= rlen && strchr(rhs, '*')); item->dst = xstrndup(rhs, rlen); + } else { + item->dst = NULL; } llen = (rhs ? (rhs - lhs - 1) : strlen(lhs)); |