diff options
| author |  Junio C Hamano <gitster@pobox.com> | 2018-11-18 18:23:56 +0900 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2018-11-18 18:23:56 +0900 |
| commit | bda53f4185b8f7d2197176fe83afcb8d5f47368b (patch) | |
| tree | 3db4c003ea5af15f7bff6246dfe6084636096be5 | |
| parent | Merge branch 'ra/rev-parse-exclude-glob' (diff) | |
| parent | apply --recount: allow "no-op hunks" (diff) | |
| download | tgif-bda53f4185b8f7d2197176fe83afcb8d5f47368b.tar.xz | |
Merge branch 'js/apply-recount-allow-noop'
When editing a patch in a "git add -i" session, a hunk could be
made to no-op. The "git apply" program used to reject a patch with
such a no-op hunk to catch user mistakes, but it is now updated to
explicitly allow a no-op hunk in an edited patch.
* js/apply-recount-allow-noop:
apply --recount: allow "no-op hunks"
| -rw-r--r-- | apply.c | 2 | ||||
| -rwxr-xr-x | t/t4136-apply-check.sh | 12 |
2 files changed, 13 insertions, 1 deletions
@@ -1748,7 +1748,7 @@ static int parse_fragment(struct apply_state *state, } if (oldlines || newlines) return -1; - if (!deleted && !added) + if (!patch->recount && !deleted && !added) return -1; fragment->leading = leading; diff --git a/t/t4136-apply-check.sh b/t/t4136-apply-check.sh index 6d92872318..4c3f264a63 100755 --- a/t/t4136-apply-check.sh +++ b/t/t4136-apply-check.sh @@ -29,6 +29,18 @@ test_expect_success 'apply exits non-zero with no-op patch' ' test_must_fail git apply --check input ' +test_expect_success '`apply --recount` allows no-op patch' ' + echo 1 >1 && + git apply --recount --check <<-\EOF + diff --get a/1 b/1 + index 6696ea4..606eddd 100644 + --- a/1 + +++ b/1 + @@ -1,1 +1,1 @@ + 1 + EOF +' + test_expect_success 'invalid combination: create and copy' ' test_must_fail git apply --check - <<-\EOF diff --git a/1 b/2 |