diff options
author | Miriam Rubio <mirucam@gmail.com> | 2020-02-17 09:40:30 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-02-19 09:37:14 -0800 |
commit | b8e3b2f33994de25c068021e388dbef72a2cdc4a (patch) | |
tree | 2298d072e5ac5dc8433ed00afe03242cbb495fa5 | |
parent | bisect--helper: change `retval` to `res` (diff) | |
download | tgif-b8e3b2f33994de25c068021e388dbef72a2cdc4a.tar.xz |
bisect: use the standard 'if (!var)' way to check for 0
Instead of using 'var == 0' in an if condition, let's use '!var' and
make 'bisect.c' more consistent with the rest of the code.
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r-- | bisect.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -572,7 +572,7 @@ static int sqrti(int val) { float d, x = val; - if (val == 0) + if (!val) return 0; do { @@ -869,7 +869,7 @@ static void check_good_are_ancestors_of_bad(struct repository *r, goto done; /* Bisecting with no good rev is ok. */ - if (good_revs.nr == 0) + if (!good_revs.nr) goto done; /* Check if all good revs are ancestor of the bad rev. */ |