diff options
| author |  Denton Liu <liu.denton@gmail.com> | 2019-12-20 10:15:48 -0800 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2019-12-20 11:30:44 -0800 |
| commit | b8afb908c261752310d4792f901c68fe27b77b40 (patch) | |
| tree | 48a81a8e3c6916c7f23f04e6d0e5ad6259148c4e | |
| parent | Git 2.24.1 (diff) | |
| download | tgif-b8afb908c261752310d4792f901c68fe27b77b40.tar.xz | |
t/lib-git-p4: use test_path_is_missing()
Previously, cleanup_git() would use `test_must_fail test -d` to ensure
that the directory is removed. However, test_must_fail should only be
used for git commands. Use test_path_is_missing() instead to check that
the directory has been removed.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | t/lib-git-p4.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh index 547b9f88e1..5aff2abe8b 100644 --- a/t/lib-git-p4.sh +++ b/t/lib-git-p4.sh @@ -175,7 +175,7 @@ stop_and_cleanup_p4d () { cleanup_git () { retry_until_success rm -r "$git" - test_must_fail test -d "$git" && + test_path_is_missing "$git" && retry_until_success mkdir "$git" } |