diff options
| author |  Johannes Schindelin <johannes.schindelin@gmx.de> | 2009-01-28 00:07:36 +0100 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2009-01-27 15:16:41 -0800 |
| commit | b8469ad0578d6b84ec92752a5f8df3ca5828af77 (patch) | |
| tree | 17e43c7238c62fbdf153a2b5d1ff3cd36dfcc4e0 | |
| parent | get_sha1_basic(): fix invalid memory access, found by valgrind (diff) | |
| download | tgif-b8469ad0578d6b84ec92752a5f8df3ca5828af77.tar.xz | |
test-path-utils: Fix off by one, found by valgrind
When normalizing an absolute path, we might have to add a slash _and_ a
NUL to the buffer, so the buffer was one too small.
Let's just future proof the code and alloc PATH_MAX + 1 bytes.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | test-path-utils.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test-path-utils.c b/test-path-utils.c index a0bcb0e210..2c0f5a37e8 100644 --- a/test-path-utils.c +++ b/test-path-utils.c @@ -3,7 +3,7 @@ int main(int argc, char **argv) { if (argc == 3 && !strcmp(argv[1], "normalize_absolute_path")) { - char *buf = xmalloc(strlen(argv[2])+1); + char *buf = xmalloc(PATH_MAX + 1); int rv = normalize_absolute_path(buf, argv[2]); assert(strlen(buf) == rv); puts(buf); |