summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Jacob Vosmaer <jacob@gitlab.com>2021-02-02 20:24:17 +0100
committerLibravatar Junio C Hamano <gitster@pobox.com>2021-02-02 12:21:38 -0800
commitad6b5fefbd15f08a32145e77d0c08394c7f17b9c (patch)
tree98f4420267dfa910b84cbef3b0166e6ac5173a6a
parentupload-pack.c: fix filter spec quoting bug (diff)
downloadtgif-ad6b5fefbd15f08a32145e77d0c08394c7f17b9c.tar.xz
t5544: clarify 'hook works with partial clone' test
Apply a few leftover improvements from the review of ad5df6b782 (upload-pack.c: fix filter spec quoting bug). 1. Instead of enumerating objects reachable from HEAD, enumerate all reachable objects, because HEAD has not special significance in this test. 2. Instead of relying on the knowledge that "? in rev-list output means partial clone", explicitly verify that there are no blobs with cat-file. Signed-off-by: Jacob Vosmaer <jacob@gitlab.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-xt/t5544-pack-objects-hook.sh5
1 files changed, 3 insertions, 2 deletions
diff --git a/t/t5544-pack-objects-hook.sh b/t/t5544-pack-objects-hook.sh
index f5ba663d64..dd5f44d986 100755
--- a/t/t5544-pack-objects-hook.sh
+++ b/t/t5544-pack-objects-hook.sh
@@ -64,8 +64,9 @@ test_expect_success 'hook works with partial clone' '
test_config_global uploadpack.packObjectsHook ./hook &&
test_config_global uploadpack.allowFilter true &&
git clone --bare --no-local --filter=blob:none . dst.git &&
- git -C dst.git rev-list --objects --missing=print HEAD >objects &&
- grep "^?" objects
+ git -C dst.git rev-list --objects --missing=allow-any --no-object-names --all >objects &&
+ git -C dst.git cat-file --batch-check="%(objecttype)" <objects >types &&
+ ! grep blob types
'
test_done