diff options
| author |  Junio C Hamano <gitster@pobox.com> | 2021-11-23 14:48:04 -0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2021-11-23 14:48:04 -0800 |
| commit | ad03180c5cf233b2de6b7e3388d96d2126d7a5d9 (patch) | |
| tree | 27651d488d9f3829abbf8e4c1581833a222d361d | |
| parent | Merge branch 'hm/paint-hits-in-log-grep' into maint (diff) | |
| parent | pull: should be noop when already-up-to-date (diff) | |
| download | tgif-ad03180c5cf233b2de6b7e3388d96d2126d7a5d9.tar.xz | |
Merge branch 'ev/pull-already-up-to-date-is-noop' into maint
"git pull" with any strategy when the other side is behind us
should succeed as it is a no-op, but doesn't.
* ev/pull-already-up-to-date-is-noop:
pull: should be noop when already-up-to-date
| -rw-r--r-- | builtin/pull.c | 6 | ||||
| -rwxr-xr-x | t/t7601-merge-pull-config.sh | 6 |
2 files changed, 10 insertions, 2 deletions
diff --git a/builtin/pull.c b/builtin/pull.c index 127798ba84..1cfaf9f343 100644 --- a/builtin/pull.c +++ b/builtin/pull.c @@ -988,6 +988,7 @@ int cmd_pull(int argc, const char **argv, const char *prefix) struct object_id rebase_fork_point; int rebase_unspecified = 0; int can_ff; + int divergent; if (!getenv("GIT_REFLOG_ACTION")) set_reflog_message(argc, argv); @@ -1102,15 +1103,16 @@ int cmd_pull(int argc, const char **argv, const char *prefix) } can_ff = get_can_ff(&orig_head, &merge_heads); + divergent = !can_ff && !already_up_to_date(&orig_head, &merge_heads); /* ff-only takes precedence over rebase */ if (opt_ff && !strcmp(opt_ff, "--ff-only")) { - if (!can_ff && !already_up_to_date(&orig_head, &merge_heads)) + if (divergent) die_ff_impossible(); opt_rebase = REBASE_FALSE; } /* If no action specified and we can't fast forward, then warn. */ - if (!opt_ff && rebase_unspecified && !can_ff) { + if (!opt_ff && rebase_unspecified && divergent) { show_advice_pull_non_ff(); die(_("Need to specify how to reconcile divergent branches.")); } diff --git a/t/t7601-merge-pull-config.sh b/t/t7601-merge-pull-config.sh index 6275641b9c..bd238d89b0 100755 --- a/t/t7601-merge-pull-config.sh +++ b/t/t7601-merge-pull-config.sh @@ -387,6 +387,12 @@ test_expect_success 'pull prevents non-fast-forward with "only" in pull.ff' ' test_must_fail git pull . c3 ' +test_expect_success 'already-up-to-date pull succeeds with unspecified pull.ff' ' + git reset --hard c1 && + git pull . c0 && + test "$(git rev-parse HEAD)" = "$(git rev-parse c1)" +' + test_expect_success 'already-up-to-date pull succeeds with "only" in pull.ff' ' git reset --hard c1 && test_config pull.ff only && |