diff options
author | Eric Wong <e@80x24.org> | 2019-01-02 09:38:46 +0000 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2019-01-02 10:19:05 -0800 |
commit | ace5707a803eda0f1dde3d776dc3729d3bc7759a (patch) | |
tree | 02bb7073aab1765540244c8595d573d988d19e10 | |
parent | Git 2.20.1 (diff) | |
download | tgif-ace5707a803eda0f1dde3d776dc3729d3bc7759a.tar.xz |
banned.h: mark strncat() as banned
strncat() has the same quadratic behavior as strcat() and is
difficult-to-read and bug-prone. While it hasn't yet been a
problem in git iself, strncat() found it's way into 'master'
of cgit and caused segfaults on my system.
Signed-off-by: Eric Wong <e@80x24.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r-- | banned.h | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -16,6 +16,8 @@ #define strcat(x,y) BANNED(strcat) #undef strncpy #define strncpy(x,y,n) BANNED(strncpy) +#undef strncat +#define strncat(x,y,n) BANNED(strncat) #undef sprintf #undef vsprintf |