diff options
| author |  Michael Haggerty <mhagger@alum.mit.edu> | 2017-11-05 09:42:03 +0100 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2017-11-06 10:31:07 +0900 |
| commit | a9bbbcec0d863d719dd4ae39fc2242b32c2008e7 (patch) | |
| tree | 6022a8162d7e4d78167a36a5c8bec4454aff2ce9 | |
| parent | prune_ref(): call `ref_transaction_add_update()` directly (diff) | |
| download | tgif-a9bbbcec0d863d719dd4ae39fc2242b32c2008e7.tar.xz | |
ref_transaction_update(): die on disallowed flags
Callers shouldn't be passing disallowed flags into
`ref_transaction_update()`. So instead of masking them off, treat it
as a bug if any are set.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | refs.c | 3 |
1 files changed, 2 insertions, 1 deletions
@@ -940,7 +940,8 @@ int ref_transaction_update(struct ref_transaction *transaction, return -1; } - flags &= REF_TRANSACTION_UPDATE_ALLOWED_FLAGS; + if (flags & ~REF_TRANSACTION_UPDATE_ALLOWED_FLAGS) + BUG("illegal flags 0x%x passed to ref_transaction_update()", flags); flags |= (new_oid ? REF_HAVE_NEW : 0) | (old_oid ? REF_HAVE_OLD : 0); |