diff options
| author |  Taylor Blau <me@ttaylorr.com> | 2020-04-23 15:41:02 -0600 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2020-04-23 14:58:52 -0700 |
| commit | a2d57e22803b1da0df95b0a88a34116209eeb6e6 (patch) | |
| tree | e9a7231e40de629dbff8232d8ac4da0f74a5725c | |
| parent | commit-graph.c: introduce '--[no-]check-oids' (diff) | |
| download | tgif-a2d57e22803b1da0df95b0a88a34116209eeb6e6.tar.xz | |
commit-graph.c: don't use discarded graph_name in error
When writing a commit-graph layer, we do so in a temporary file which is
renamed into place. If we fail to create a temporary file, for e.g.,
because we have too many open files, then 'git_mkstemp_mode' sets the
pattern to the empty string, in which case we get an error something
along the lines of:
error: unable to create ''
It's not useful to show the pattern here at all, since we (1) know the
pattern is well-formed, and (2) would have already shown the dirname
when trying to create the leading directories. So, replace this error
with something friendlier.
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | commit-graph.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/commit-graph.c b/commit-graph.c index af677fc98e..98bbbbfc32 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -1397,7 +1397,7 @@ static int write_commit_graph_file(struct write_commit_graph_context *ctx) fd = git_mkstemp_mode(ctx->graph_name, 0444); if (fd < 0) { - error(_("unable to create '%s'"), ctx->graph_name); + error(_("unable to create temporary graph layer")); return -1; } |