diff options
| author |  Junio C Hamano <gitster@pobox.com> | 2019-07-29 12:38:17 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2019-07-29 12:38:17 -0700 |
| commit | 9c65991abd7c954be8c3a1414f6cf365b83ee317 (patch) | |
| tree | c1b9516750692954a948cc7beafdea1088b00378 | |
| parent | Merge branch 'js/mingw-spawn-with-spaces-in-path' into maint (diff) | |
| parent | rm: resolving by removal is not a warning-worthy event (diff) | |
| download | tgif-9c65991abd7c954be8c3a1414f6cf365b83ee317.tar.xz | |
Merge branch 'jc/denoise-rm-to-resolve' into maint
"git rm" to resolve a conflicted path leaked an internal message
"needs merge" before actually removing the path, which was
confusing. This has been corrected.
* jc/denoise-rm-to-resolve:
rm: resolving by removal is not a warning-worthy event
| -rw-r--r-- | builtin/rm.c | 2 | ||||
| -rwxr-xr-x | t/t3600-rm.sh | 13 |
2 files changed, 14 insertions, 1 deletions
diff --git a/builtin/rm.c b/builtin/rm.c index 90cbe896c9..bf4a443e13 100644 --- a/builtin/rm.c +++ b/builtin/rm.c @@ -273,7 +273,7 @@ int cmd_rm(int argc, const char **argv, const char *prefix) parse_pathspec(&pathspec, 0, PATHSPEC_PREFER_CWD, prefix, argv); - refresh_index(&the_index, REFRESH_QUIET, &pathspec, NULL, NULL); + refresh_index(&the_index, REFRESH_QUIET|REFRESH_UNMERGED, &pathspec, NULL, NULL); seen = xcalloc(pathspec.nr, 1); diff --git a/t/t3600-rm.sh b/t/t3600-rm.sh index 85ae7dc1e4..66282a720e 100755 --- a/t/t3600-rm.sh +++ b/t/t3600-rm.sh @@ -252,6 +252,19 @@ test_expect_success 'choking "git rm" should not let it die with cruft' ' test_path_is_missing .git/index.lock ' +test_expect_success 'Resolving by removal is not a warning-worthy event' ' + git reset -q --hard && + test_when_finished "rm -f .git/index.lock msg && git reset -q --hard" && + blob=$(echo blob | git hash-object -w --stdin) && + for stage in 1 2 3 + do + echo "100644 $blob $stage blob" + done | git update-index --index-info && + git rm blob >msg 2>&1 && + test_i18ngrep ! "needs merge" msg && + test_must_fail git ls-files -s --error-unmatch blob +' + test_expect_success 'rm removes subdirectories recursively' ' mkdir -p dir/subdir/subsubdir && echo content >dir/subdir/subsubdir/file && |