summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Luke Diamand <luke@diamand.org>2015-05-19 23:23:16 +0100
committerLibravatar Junio C Hamano <gitster@pobox.com>2015-05-24 11:50:12 -0700
commit9afbb2dc371441ad250d5e094277699b58dbd88c (patch)
tree5b9aafaf33c92b007d3b71a4c1545cb5c38d41e8
parentGit 2.3.7 (diff)
downloadtgif-9afbb2dc371441ad250d5e094277699b58dbd88c.tar.xz
git-p4: add failing test for P4EDITOR handling
Add test case that git-p4 handles a setting of P4EDITOR that takes arguments, e.g. "gvim -f". This currently fails. Signed-off-by: Luke Diamand <luke@diamand.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-xt/t9820-git-p4-editor-handling.sh38
1 files changed, 38 insertions, 0 deletions
diff --git a/t/t9820-git-p4-editor-handling.sh b/t/t9820-git-p4-editor-handling.sh
new file mode 100755
index 0000000000..abaa0663b8
--- /dev/null
+++ b/t/t9820-git-p4-editor-handling.sh
@@ -0,0 +1,38 @@
+#!/bin/sh
+
+test_description='git p4 handling of EDITOR'
+
+. ./lib-git-p4.sh
+
+test_expect_success 'start p4d' '
+ start_p4d
+'
+
+test_expect_success 'init depot' '
+ (
+ cd "$cli" &&
+ echo file1 >file1 &&
+ p4 add file1 &&
+ p4 submit -d "file1"
+ )
+'
+
+# Check that the P4EDITOR argument can be given command-line
+# options, which git-p4 will then pass through to the shell.
+test_expect_failure 'EDITOR with options' '
+ git p4 clone --dest="$git" //depot &&
+ test_when_finished cleanup_git &&
+ (
+ cd "$git" &&
+ echo change >file1 &&
+ git commit -m "change" file1 &&
+ P4EDITOR=": >\"$git/touched\" && test-chmtime +5" git p4 submit &&
+ test_path_is_file "$git/touched"
+ )
+'
+
+test_expect_success 'kill p4d' '
+ kill_p4d
+'
+
+test_done