diff options
| author |  Xin Li <delphij@google.com> | 2020-06-05 02:10:03 -0700 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2020-06-05 10:13:30 -0700 |
| commit | 98564d805938cae8b72687a9e39d65b00ac7ad27 (patch) | |
| tree | 78a12f098bdac401631df84dbf1c681b5d1991d7 | |
| parent | fetch: allow adding a filter after initial clone (diff) | |
| download | tgif-98564d805938cae8b72687a9e39d65b00ac7ad27.tar.xz | |
sparse-checkout: upgrade repository to version 1 when enabling extension
The 'extensions' configuration variable gets special meaning in the new
repository version, so when enabling the extension we should upgrade the
repository to version 1.
Signed-off-by: Xin Li <delphij@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin/sparse-checkout.c | 2 | ||||
| -rwxr-xr-x | t/t2404-worktree-config.sh | 4 |
2 files changed, 5 insertions, 1 deletions
diff --git a/builtin/sparse-checkout.c b/builtin/sparse-checkout.c index 95d0882417..95669815d4 100644 --- a/builtin/sparse-checkout.c +++ b/builtin/sparse-checkout.c @@ -249,6 +249,8 @@ static int set_config(enum sparse_checkout_mode mode) { const char *config_path; + if (upgrade_repository_format(1) < 0) + die(_("unable to upgrade repository format to enable worktreeConfig")); if (git_config_set_gently("extensions.worktreeConfig", "true")) { error(_("failed to set extensions.worktreeConfig setting")); return 1; diff --git a/t/t2404-worktree-config.sh b/t/t2404-worktree-config.sh index 286121d8de..9536d10919 100755 --- a/t/t2404-worktree-config.sh +++ b/t/t2404-worktree-config.sh @@ -23,8 +23,10 @@ test_expect_success 'config --worktree without extension' ' ' test_expect_success 'enable worktreeConfig extension' ' + git config core.repositoryformatversion 1 && git config extensions.worktreeConfig true && - test_cmp_config true extensions.worktreeConfig + test_cmp_config true extensions.worktreeConfig && + test_cmp_config 1 core.repositoryformatversion ' test_expect_success 'config is shared as before' ' |