diff options
| author |  Ben Peart <peartben@gmail.com> | 2017-05-05 11:27:54 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2017-05-08 10:57:26 +0900 |
| commit | 974b50c5565107e1e3209176682ee6f6e420bd2b (patch) | |
| tree | 39fb555270c308253f9b5ebc61abda4f13f2ac33 | |
| parent | convert: remove erroneous tests for errno == EPIPE (diff) | |
| download | tgif-974b50c5565107e1e3209176682ee6f6e420bd2b.tar.xz | |
pkt-line: fix packet_read_line() to handle len < 0 errors
Update packet_read_line() to test for len > 0 to avoid potential bug
if read functions return lengths less than zero to indicate errors.
Signed-off-by: Ben Peart <benpeart@microsoft.com>
Found/Fixed-by: Lars Schneider <larsxschneider@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | pkt-line.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pkt-line.c b/pkt-line.c index d4b6bfe076..6f05b1a4a8 100644 --- a/pkt-line.c +++ b/pkt-line.c @@ -315,7 +315,7 @@ static char *packet_read_line_generic(int fd, PACKET_READ_CHOMP_NEWLINE); if (dst_len) *dst_len = len; - return len ? packet_buffer : NULL; + return (len > 0) ? packet_buffer : NULL; } char *packet_read_line(int fd, int *len_p) |