summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Johannes Sixt <j6t@kdbg.org>2011-01-11 08:44:30 +0100
committerLibravatar Junio C Hamano <gitster@pobox.com>2011-01-11 10:51:25 -0800
commit95b104c830caa74a5702bcabc3bbb920b0eba07d (patch)
treee9a85db4170664754f4a49c96da483e612587ee6
parentFix expected values of setup tests on Windows (diff)
downloadtgif-95b104c830caa74a5702bcabc3bbb920b0eba07d.tar.xz
t/README: hint about using $(pwd) rather than $PWD in tests
This adds just a "do it this way" instruction without a lot of explanation, because the details are too complex to be explained at this point. Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--t/README6
1 files changed, 6 insertions, 0 deletions
diff --git a/t/README b/t/README
index 892d443f63..25f7d2d2e3 100644
--- a/t/README
+++ b/t/README
@@ -283,6 +283,12 @@ Do:
Tests that are likely to smoke out future regressions are better
than tests that just inflate the coverage metrics.
+ - When a test checks for an absolute path that a git command generated,
+ construct the expected value using $(pwd) rather than $PWD,
+ $TEST_DIRECTORY, or $TRASH_DIRECTORY. It makes a difference on
+ Windows, where the shell (MSYS bash) mangles absolute path names.
+ For details, see the commit message of 4114156ae9.
+
Don't:
- exit() within a <script> part.