summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Paul Mackerras <paulus@samba.org>2008-05-19 09:48:45 +1000
committerLibravatar Paul Mackerras <paulus@samba.org>2008-05-19 09:48:45 +1000
commit94503a66c56c935e77a8fbe3622f1f56b7134ccc (patch)
tree3643ff39ea49e065b331b7b6dd0e32c56b98b94b
parentgitk: Add a progress bar for checking out a head (diff)
downloadtgif-94503a66c56c935e77a8fbe3622f1f56b7134ccc.tar.xz
gitk: Fix "wrong # coordinates" error on reload
This fixes the Tk error "wrong # coordinates: expected 0 or 4, got 2" that sometimes occurred when reloading. The problem was that we didn't unset the variables containing the canvas item id numbers for the displayed rows when we cleared the canvases. Thus make_secsel would think it had something to do when it didn't. Thanks to Michele Ballabio for finding a way to trigger the bug reliably. Signed-off-by: Paul Mackerras <paulus@samba.org>
-rwxr-xr-xgitk4
1 files changed, 4 insertions, 0 deletions
diff --git a/gitk b/gitk
index 9ab6dbaa46..998a051942 100755
--- a/gitk
+++ b/gitk
@@ -5125,10 +5125,14 @@ proc drawvisible {} {
proc clear_display {} {
global iddrawn linesegs need_redisplay nrows_drawn
global vhighlights fhighlights nhighlights rhighlights
+ global linehtag linentag linedtag
allcanvs delete all
catch {unset iddrawn}
catch {unset linesegs}
+ catch {unset linehtag}
+ catch {unset linentag}
+ catch {unset linedtag}
catch {unset vhighlights}
catch {unset fhighlights}
catch {unset nhighlights}