diff options
| author |  Elia Pinto <gitter.spiros@gmail.com> | 2015-12-22 15:10:32 +0100 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2015-12-27 15:33:13 -0800 |
| commit | 92bea9530ba2a69cc0f0e3a3d67e60fafb2444d9 (patch) | |
| tree | 01b065abfe022a2c2f5dd98eca2821cdccabdd3d | |
| parent | test-sha1.sh: use the $( ... ) construct for command substitution (diff) | |
| download | tgif-92bea9530ba2a69cc0f0e3a3d67e60fafb2444d9.tar.xz | |
unimplemented.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | unimplemented.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/unimplemented.sh b/unimplemented.sh index 5252de4b25..fee21d24e8 100644 --- a/unimplemented.sh +++ b/unimplemented.sh @@ -1,4 +1,4 @@ #!/bin/sh -echo >&2 "fatal: git was built without support for `basename $0` (@@REASON@@)." +echo >&2 "fatal: git was built without support for $(basename $0) (@@REASON@@)." exit 128 |