diff options
| author |  Jeff King <peff@peff.net> | 2020-12-01 13:11:38 -0800 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2020-12-02 14:30:39 -0800 |
| commit | 91aef030152d121f6b4bc3b933c696073ba073e2 (patch) | |
| tree | 576aabc81144240c2a5574c481f7fa77a64d54f3 | |
| parent | banned.h: mark non-reentrant gmtime, etc as banned (diff) | |
| download | tgif-91aef030152d121f6b4bc3b933c696073ba073e2.tar.xz | |
banned.h: mark ctime_r() and asctime_r() as banned
The ctime_r() and asctime_r() functions are reentrant, but have
no check that the buffer we pass in is long enough (the manpage says it
"should have room for at least 26 bytes"). Since this is such an
easy-to-get-wrong interface, and since we have the much safer strftime()
as well as its more convenient strbuf_addftime() wrapper, let's ban both
of those.
Signed-off-by: Jeff King <peff@peff.net>
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | banned.h | 4 |
1 files changed, 4 insertions, 0 deletions
@@ -35,7 +35,11 @@ #define localtime(t) BANNED(localtime) #undef ctime #define ctime(t) BANNED(ctime) +#undef ctime_r +#define ctime_r(t, buf) BANNED(ctime_r) #undef asctime #define asctime(t) BANNED(asctime) +#undef asctime_r +#define asctime_r(t, buf) BANNED(asctime_r) #endif /* BANNED_H */ |