summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Junio C Hamano <gitster@pobox.com>2009-07-25 01:31:53 -0700
committerLibravatar Junio C Hamano <gitster@pobox.com>2009-07-25 01:31:53 -0700
commit8f5e3ca7d1d9c987c5a50934f1acdbad44163f3b (patch)
treec1093f41bebfaa211a072faf887d7d283f493ae3
parentUpdate release notes for 1.6.4 (diff)
parentFix severe breakage in "git-apply --whitespace=fix" (diff)
downloadtgif-8f5e3ca7d1d9c987c5a50934f1acdbad44163f3b.tar.xz
Merge branch 'maint'
* maint: Fix severe breakage in "git-apply --whitespace=fix"
-rwxr-xr-xt/t4124-apply-ws-rule.sh10
-rw-r--r--ws.c4
2 files changed, 9 insertions, 5 deletions
diff --git a/t/t4124-apply-ws-rule.sh b/t/t4124-apply-ws-rule.sh
index 5698a9a736..fac2093d7f 100755
--- a/t/t4124-apply-ws-rule.sh
+++ b/t/t4124-apply-ws-rule.sh
@@ -154,7 +154,9 @@ create_patch () {
index e69de29..8bd6648 100644
--- a/target
+++ b/target
- @@ -0,0 +1 @@
+ @@ -0,0 +1,3 @@
+ +An empty line follows
+ +
+A line with trailing whitespace and no newline_
\ No newline at end of file
EOF
@@ -162,8 +164,10 @@ create_patch () {
test_expect_success 'trailing whitespace & no newline at the end of file' '
>target &&
- create_patch | git apply --whitespace=fix - &&
- grep "newline$" target
+ create_patch >patch-file &&
+ git apply --whitespace=fix patch-file &&
+ grep "newline$" target &&
+ grep "^$" target
'
test_done
diff --git a/ws.c b/ws.c
index 8d855b7fd5..59d0883c1f 100644
--- a/ws.c
+++ b/ws.c
@@ -262,10 +262,10 @@ int ws_fix_copy(char *dst, const char *src, int len, unsigned ws_rule, int *erro
* Strip trailing whitespace
*/
if (ws_rule & WS_TRAILING_SPACE) {
- if (1 < len && src[len - 1] == '\n') {
+ if (0 < len && src[len - 1] == '\n') {
add_nl_to_tail = 1;
len--;
- if (1 < len && src[len - 1] == '\r') {
+ if (0 < len && src[len - 1] == '\r') {
add_cr_to_tail = !!(ws_rule & WS_CR_AT_EOL);
len--;
}