diff options
| author |  David Aguilar <davvid@gmail.com> | 2021-09-30 18:37:55 -0700 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2021-09-30 18:48:51 -0700 |
| commit | 8e2af8f0db329a8c0211a309fa9cb611b6dc2517 (patch) | |
| tree | 3a68d28d2a36f78af554d4f1949e4e96df7bf991 | |
| parent | difftool: refactor dir-diff to write files using helper functions (diff) | |
| download | tgif-8e2af8f0db329a8c0211a309fa9cb611b6dc2517.tar.xz | |
difftool: remove an unnecessary call to strbuf_release()
The `buf` strbuf is reused again later in the same function, so there
is no benefit to calling strbuf_release(). The subsequent usage is
already using strbuf_reset() to reset the buffer, so releasing it
early is only going to lead to a wasteful reallocation.
Remove the early call to strbuf_release(). The same strbuf is already
cleaned up in the "finish:" section so nothing is leaked, either.
Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin/difftool.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/builtin/difftool.c b/builtin/difftool.c index be7ed2acaa..1a415a15a3 100644 --- a/builtin/difftool.c +++ b/builtin/difftool.c @@ -568,8 +568,6 @@ static int run_dir_diff(const char *extcmd, int symlinks, const char *prefix, write_standin_files(entry, &ldir, ldir_len, &rdir, rdir_len); } - strbuf_release(&buf); - strbuf_setlen(&ldir, ldir_len); helper_argv[1] = ldir.buf; strbuf_setlen(&rdir, rdir_len); |