summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Johannes Schindelin <Johannes.Schindelin@gmx.de>2007-01-16 22:10:54 +0100
committerLibravatar Junio C Hamano <junkio@cox.net>2007-01-16 13:43:50 -0800
commit8bef62049b46038334ed6f065fdac27758070a5e (patch)
tree120dd6e8f225aa410649e604f4d476b980dd70c8
parentgit-rm documentation: remove broken behaviour from the example. (diff)
downloadtgif-8bef62049b46038334ed6f065fdac27758070a5e.tar.xz
Fix spurious compile error
From time to time, I would get this error: [...] sed: -e expression #8, char 41: Unterminated `s' command make: *** [git-add--interactive] Error 1 Turns out that the function WriteMakefile() called in Makefile.PL outputs the message "Writing perl.mak for Git" to stdout! Thus, the output of "make -C perl -s --no-print-directory instlibdir" would be prefixed by that message whenever Makefile.PL was newer than perl.mak. This is fixed by redirecting stdout to stderr in Makefile.PL. Signed-off-by: Johannes E. Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <junkio@cox.net>
-rw-r--r--perl/Makefile.PL4
1 files changed, 4 insertions, 0 deletions
diff --git a/perl/Makefile.PL b/perl/Makefile.PL
index 41687757a7..9b117fd0d7 100644
--- a/perl/Makefile.PL
+++ b/perl/Makefile.PL
@@ -20,6 +20,10 @@ if ($@) {
my %extra;
$extra{DESTDIR} = $ENV{DESTDIR} if $ENV{DESTDIR};
+# redirect stdout, otherwise the message "Writing perl.mak for Git"
+# disrupts the output for the target 'instlibdir'
+open STDOUT, ">&STDERR";
+
WriteMakefile(
NAME => 'Git',
VERSION_FROM => 'Git.pm',