diff options
| author |  Dmitry Potapov <dpotapov@gmail.com> | 2008-09-09 00:42:48 +0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2008-09-09 08:37:48 -0700 |
| commit | 8beb1f33d15af6cdb6bf7d8296fd73eb8df2f152 (patch) | |
| tree | f97993669b5335e4aac9dceaab2a018359e64e97 | |
| parent | Update draft release notes for 1.6.0.2 (diff) | |
| download | tgif-8beb1f33d15af6cdb6bf7d8296fd73eb8df2f152.tar.xz | |
git-rebase-interactive: do not squash commits on abort
If git rebase interactive is stopped by "edit" command and then the user
said "git rebase --continue" while having some stage changes, git rebase
interactive is trying to amend the last commit by doing:
git --soft reset && git commit
However, the user can abort commit for some reason by providing an empty
log message, and that would leave the last commit undone, while the user
being completely unaware about what happened. Now if the user tries to
continue, by issuing "git rebase --continue" that squashes two previous
commits.
Signed-off-by: Dmitry Potapov <dpotapov@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | git-rebase--interactive.sh | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 929d681c47..990104a52d 100755 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -427,14 +427,18 @@ do else . "$DOTEST"/author-script || die "Cannot find the author identity" + amend= if test -f "$DOTEST"/amend then + amend=$(git rev-parse --verify HEAD) git reset --soft HEAD^ || die "Cannot rewind the HEAD" fi export GIT_AUTHOR_NAME GIT_AUTHOR_EMAIL GIT_AUTHOR_DATE && - git commit --no-verify -F "$DOTEST"/message -e || - die "Could not commit staged changes." + git commit --no-verify -F "$DOTEST"/message -e || { + test -n "$amend" && git reset --soft $amend + die "Could not commit staged changes." + } fi require_clean_work_tree |