summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Josh Steadmon <steadmon@google.com>2019-01-15 14:25:52 -0800
committerLibravatar Junio C Hamano <gitster@pobox.com>2019-01-15 20:32:00 -0800
commit8b7c2eee7d2e6470a6d5484614e491d4a4571d09 (patch)
treef63e39a9c4d9be57b380adf957f63422090bd2e6
parentcommit-graph: fix buffer read-overflow (diff)
downloadtgif-8b7c2eee7d2e6470a6d5484614e491d4a4571d09.tar.xz
Makefile: correct example fuzz build
The comment explaining how to build the fuzzers was broken in 927c77e7d4d ("Makefile: use FUZZ_CXXFLAGS for linking fuzzers", 2018-11-14). When building fuzzers, all .c files must be compiled with coverage tracing enabled. This is not possible when using only FUZZ_CXXFLAGS, as that flag is only applied to the fuzzers themselves. Switching back to CFLAGS fixes the issue. Signed-off-by: Josh Steadmon <steadmon@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--Makefile2
1 files changed, 1 insertions, 1 deletions
diff --git a/Makefile b/Makefile
index 6b72f37c29..bbcfc2bc9f 100644
--- a/Makefile
+++ b/Makefile
@@ -3104,7 +3104,7 @@ cover_db_html: cover_db
# An example command to build against libFuzzer from LLVM 4.0.0:
#
# make CC=clang CXX=clang++ \
-# FUZZ_CXXFLAGS="-fsanitize-coverage=trace-pc-guard -fsanitize=address" \
+# CFLAGS="-fsanitize-coverage=trace-pc-guard -fsanitize=address" \
# LIB_FUZZING_ENGINE=/usr/lib/llvm-4.0/lib/libFuzzer.a \
# fuzz-all
#