diff options
author | Junio C Hamano <gitster@pobox.com> | 2009-03-24 19:45:57 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2009-03-24 19:45:57 -0700 |
commit | 89fbda24256157cc43848488429fd20cf3bb21ab (patch) | |
tree | 0e896125f1dfc70eed99f703b22494540c9a5000 | |
parent | Add warning about known issues to documentation of cvsimport (diff) | |
parent | Increase the size of the die/warning buffer to avoid truncation (diff) | |
download | tgif-89fbda24256157cc43848488429fd20cf3bb21ab.tar.xz |
Merge branch 'maint'
* maint:
Increase the size of the die/warning buffer to avoid truncation
close_sha1_file(): make it easier to diagnose errors
avoid possible overflow in delta size filtering computation
-rw-r--r-- | builtin-pack-objects.c | 2 | ||||
-rw-r--r-- | sha1_file.c | 2 | ||||
-rw-r--r-- | usage.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c index 1c6d2c498b..2000d97ec4 100644 --- a/builtin-pack-objects.c +++ b/builtin-pack-objects.c @@ -1293,7 +1293,7 @@ static int try_delta(struct unpacked *trg, struct unpacked *src, max_size = trg_entry->delta_size; ref_depth = trg->depth; } - max_size = max_size * (max_depth - src->depth) / + max_size = (uint64_t)max_size * (max_depth - src->depth) / (max_depth - ref_depth + 1); if (max_size == 0) return 0; diff --git a/sha1_file.c b/sha1_file.c index 456317356f..54972f97e0 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -2287,7 +2287,7 @@ static void close_sha1_file(int fd) fsync_or_die(fd, "sha1 file"); fchmod(fd, 0444); if (close(fd) != 0) - die("unable to write sha1 file"); + die("error when closing sha1 file (%s)", strerror(errno)); } /* Size of directory component, including the ending '/' */ @@ -7,7 +7,7 @@ static void report(const char *prefix, const char *err, va_list params) { - char msg[256]; + char msg[1024]; vsnprintf(msg, sizeof(msg), err, params); fprintf(stderr, "%s%s\n", prefix, msg); } |