diff options
| author |  Jeff King <peff@peff.net> | 2012-01-09 17:55:42 -0500 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2012-01-09 15:15:28 -0800 |
| commit | 829a1c616967176ccd859c18a6e8ca0dda77f75a (patch) | |
| tree | 40d782c981b910f9bcbb78881014fe92f66a3d38 | |
| parent | Git 1.7.8.3 (diff) | |
| download | tgif-829a1c616967176ccd859c18a6e8ca0dda77f75a.tar.xz | |
send-email: multiedit is a boolean config option
The sendemail.multiedit variable is meant to be a boolean.
However, it is not marked as such in the code, which means
we store its value literally. Thus in the do_edit function,
perl ends up coercing it to a boolean value according to
perl rules, not git rules. This works for "0", but "false",
"no", or "off" will erroneously be interpreted as true.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | git-send-email.perl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/git-send-email.perl b/git-send-email.perl index d491db92c9..ef30c557c7 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -210,6 +210,7 @@ my %config_bool_settings = ( "signedoffbycc" => [\$signed_off_by_cc, undef], "signedoffcc" => [\$signed_off_by_cc, undef], # Deprecated "validate" => [\$validate, 1], + "multiedit" => [\$multiedit, undef] ); my %config_settings = ( @@ -227,7 +228,6 @@ my %config_settings = ( "bcc" => \@bcclist, "suppresscc" => \@suppress_cc, "envelopesender" => \$envelope_sender, - "multiedit" => \$multiedit, "confirm" => \$confirm, "from" => \$sender, "assume8bitencoding" => \$auto_8bit_encoding, |