summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Ariel Badichi <abadichi@bezeqint.net>2008-04-23 04:06:27 +0300
committerLibravatar Junio C Hamano <gitster@pobox.com>2008-04-22 21:23:16 -0700
commit75b7dfbdc030cfc6f09a6317444c36c4957a9133 (patch)
tree6f136ef87cf2fa585e96d610586d2ceea7ac88b4
parentcopy.c: copy_fd - correctly report write errors (diff)
downloadtgif-75b7dfbdc030cfc6f09a6317444c36c4957a9133.tar.xz
archive.c: format_subst - fixed bogus argument to memchr
Also removed a superfluous test. Signed-off-by: Ariel Badichi <abadichi@bezeqint.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--archive.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/archive.c b/archive.c
index fb159fe59e..7a32c19d3c 100644
--- a/archive.c
+++ b/archive.c
@@ -16,9 +16,9 @@ static void format_subst(const struct commit *commit,
const char *b, *c;
b = memmem(src, len, "$Format:", 8);
- if (!b || src + len < b + 9)
+ if (!b)
break;
- c = memchr(b + 8, '$', len - 8);
+ c = memchr(b + 8, '$', (src + len) - b - 8);
if (!c)
break;