diff options
| author |  Shourya Shukla <shouryashukla.oo@gmail.com> | 2020-08-21 22:29:49 +0530 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2020-08-21 11:47:55 -0700 |
| commit | 7303da30021761b3a7c862d795e67ab74b5d66eb (patch) | |
| tree | b5ac0241c07ef8a420c79047670bc587aab0c406 | |
| parent | t7401: modernize style (diff) | |
| download | tgif-7303da30021761b3a7c862d795e67ab74b5d66eb.tar.xz | |
t7401: use 'short' instead of 'verify' and cut in rev-parse calls
'git rev-parse' can limit the number of characters in the hash it
outputs using the '--short' option, thereby, making the 'cut' invocation
redundant. Since using '--short' implies '--verify' as well, we can
safely replace the latter with the former. This change results in the
helper functions getting the hash in the same way 'summary' gets the
hash internally.
So, avoid the unnecessary invocation to 'cut' in the helper
functions.
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t7401-submodule-summary.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh index 07d4ba0b26..ccbac875fe 100755 --- a/t/t7401-submodule-summary.sh +++ b/t/t7401-submodule-summary.sh @@ -21,7 +21,7 @@ add_file () { test_tick && git commit -m "Add $name" done >/dev/null - git rev-parse --verify HEAD | cut -c1-7 + git rev-parse --short HEAD cd "$owd" } commit_file () { @@ -125,7 +125,7 @@ commit_file sm1 && head3=$( cd sm1 && git reset --hard HEAD~2 >/dev/null && - git rev-parse --verify HEAD | cut -c1-7 + git rev-parse --short HEAD ) test_expect_success 'modified submodule(backward)' " |