summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Junio C Hamano <gitster@pobox.com>2020-04-22 08:55:11 -0700
committerLibravatar Junio C Hamano <gitster@pobox.com>2020-04-22 08:55:11 -0700
commit719483e547a30819e3dbaa252f0e036e23efa561 (patch)
treebdebdacf465a68d3b54f9e20c359217bf48058e5
parentbuiltin/receive-pack: use constant-time comparison for HMAC value (diff)
downloadtgif-719483e547a30819e3dbaa252f0e036e23efa561.tar.xz
receive-pack: compilation fix
We do not use C99 "for loop initial declaration" in our codebase (yet), but one snuck in. Reported-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--builtin/receive-pack.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index 45e2dd2a65..66149777a0 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -505,7 +505,9 @@ static char *find_header(const char *msg, size_t len, const char *key,
static int constant_memequal(const char *a, const char *b, size_t n)
{
int res = 0;
- for (size_t i = 0; i < n; i++)
+ size_t i;
+
+ for (i = 0; i < n; i++)
res |= a[i] ^ b[i];
return res;
}