summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar René Scharfe <l.s.r@web.de>2021-09-04 09:50:58 +0200
committerLibravatar Junio C Hamano <gitster@pobox.com>2021-09-07 13:03:13 -0700
commit709b3f32d333df1e29dbb073b4e9e834f130a989 (patch)
treec06e851e11818e8641e8a2bb96a5adff8bfc7828
parentGit 2.33 (diff)
downloadtgif-709b3f32d333df1e29dbb073b4e9e834f130a989.tar.xz
range-diff: avoid segfault with -I
output() reuses the same struct diff_options for multiple calls of diff_flush(). Set the option no_free to instruct it to keep the ignore regexes between calls and release them explicitly at the end. Signed-off-by: René Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--range-diff.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/range-diff.c b/range-diff.c
index e9479794b4..a315c4c889 100644
--- a/range-diff.c
+++ b/range-diff.c
@@ -485,6 +485,7 @@ static void output(struct string_list *a, struct string_list *b,
else
diff_setup(&opts);
+ opts.no_free = 1;
if (!opts.output_format)
opts.output_format = DIFF_FORMAT_PATCH;
opts.flags.suppress_diff_headers = 1;
@@ -545,6 +546,8 @@ static void output(struct string_list *a, struct string_list *b,
strbuf_release(&buf);
strbuf_release(&dashes);
strbuf_release(&indent);
+ opts.no_free = 0;
+ diff_free(&opts);
}
int show_range_diff(const char *range1, const char *range2,