diff options
| author |  Christian Couder <christian.couder@gmail.com> | 2018-01-05 10:12:20 +0100 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2018-01-05 12:31:07 -0800 |
| commit | 6f5ecad6a5566ac8dfb30c58330d53ef6cd5ad03 (patch) | |
| tree | 057411a67060965e046eaf76ec8ac0645963face | |
| parent | perf: store subsection results in "test-results/$GIT_PERF_SUBSECTION/" (diff) | |
| download | tgif-6f5ecad6a5566ac8dfb30c58330d53ef6cd5ad03.tar.xz | |
perf/aggregate: fix checking ENV{GIT_PERF_SUBSECTION}
The way we check ENV{GIT_PERF_SUBSECTION} could trigger
comparison between undef and "" that may be flagged by
use of strict & warnings. Let's fix that.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/perf/aggregate.perl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl index e401208488..769d418708 100755 --- a/t/perf/aggregate.perl +++ b/t/perf/aggregate.perl @@ -70,7 +70,7 @@ if (not @tests) { } my $resultsdir = "test-results"; -if ($ENV{GIT_PERF_SUBSECTION} ne "") { +if (exists $ENV{GIT_PERF_SUBSECTION} and $ENV{GIT_PERF_SUBSECTION} ne "") { $resultsdir .= "/" . $ENV{GIT_PERF_SUBSECTION}; } |