diff options
| author |  Elia Pinto <gitter.spiros@gmail.com> | 2014-06-06 07:55:49 -0700 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2014-06-09 14:47:06 -0700 |
| commit | 6f34b79de15f92b53d050598b04444e8421d7b7d (patch) | |
| tree | 43fdf79666ce80315defab02b1afb9d1caaa162b | |
| parent | contrib/examples/git-repack.sh: avoid "test <cond> -a/-o <cond>" (diff) | |
| download | tgif-6f34b79de15f92b53d050598b04444e8421d7b7d.tar.xz | |
contrib/examples/git-resolve.sh: avoid "test <cond> -a/-o <cond>"
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test <cond> && test <cond>" spawning
one extra process by using a single "test <cond> -a <cond>" no
longer exists.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | contrib/examples/git-resolve.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/examples/git-resolve.sh b/contrib/examples/git-resolve.sh index 48d0fc971f..70fdc27b72 100755 --- a/contrib/examples/git-resolve.sh +++ b/contrib/examples/git-resolve.sh @@ -76,7 +76,7 @@ case "$common" in 2>/dev/null || continue # Count the paths that are unmerged. cnt=$(GIT_INDEX_FILE=$G git ls-files --unmerged | wc -l) - if test $best_cnt -le 0 -o $cnt -le $best_cnt + if test $best_cnt -le 0 || test $cnt -le $best_cnt then best=$c best_cnt=$cnt |