diff options
| author |  Célestin Matte <celestin.matte@ensimag.fr> | 2013-06-14 15:50:15 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2013-06-14 09:02:16 -0700 |
| commit | 6c2fbe25fb8883da7925567a582dacda679e29dc (patch) | |
| tree | 980d49f4e1889e7338aab635f02ab51368b4a65e | |
| parent | git-remote-mediawiki: change syntax of map calls (diff) | |
| download | tgif-6c2fbe25fb8883da7925567a582dacda679e29dc.tar.xz | |
git-remote-mediawiki: rewrite unclear line of instructions
Subroutines' parameters should be assigned to variable before doing anything
else
Besides, existing instruction affected a variable inside a "if", which break
Git's coding style
Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr>
Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | contrib/mw-to-git/git-remote-mediawiki.perl | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl index 3d1a324cf9..5e00833040 100755 --- a/contrib/mw-to-git/git-remote-mediawiki.perl +++ b/contrib/mw-to-git/git-remote-mediawiki.perl @@ -1333,7 +1333,8 @@ sub get_mw_namespace_id { } sub get_mw_namespace_id_for_page { - if (my ($namespace) = $_[0] =~ /^([^:]*):/) { + my $namespace = shift; + if ($namespace =~ /^([^:]*):/) { return get_mw_namespace_id($namespace); } else { return; |