summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Junio C Hamano <gitster@pobox.com>2017-09-25 15:24:09 +0900
committerLibravatar Junio C Hamano <gitster@pobox.com>2017-09-25 15:24:09 +0900
commit6b05e611bc6c7584d1af7b56e387824f99a76713 (patch)
treebc8af0e9e0f42192e5e032b14a1d18683d0a06d5
parentMerge branch 'jk/revision-remove-cmdline-pathspec' (diff)
parenttest-lint: echo -e (or -E) is not portable (diff)
downloadtgif-6b05e611bc6c7584d1af7b56e387824f99a76713.tar.xz
Merge branch 'tb/test-lint-echo-e'
The test linter has been taught that we do not like "echo -e". * tb/test-lint-echo-e: test-lint: echo -e (or -E) is not portable
-rwxr-xr-xt/check-non-portable-shell.pl2
1 files changed, 1 insertions, 1 deletions
diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl
index b170cbc045..03dc9d2852 100755
--- a/t/check-non-portable-shell.pl
+++ b/t/check-non-portable-shell.pl
@@ -17,7 +17,7 @@ sub err {
while (<>) {
chomp;
/\bsed\s+-i/ and err 'sed -i is not portable';
- /\becho\s+-n/ and err 'echo -n is not portable (please use printf)';
+ /\becho\s+-[neE]/ and err 'echo with option is not portable (please use printf)';
/^\s*declare\s+/ and err 'arrays/declare not portable';
/^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)';
/\btest\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';