diff options
| author |  Junio C Hamano <gitster@pobox.com> | 2014-04-30 14:24:24 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-05-02 13:24:57 -0700 |
| commit | 6a49909b52b48592234da6a53bfe74ea34c302c6 (patch) | |
| tree | 77ccd75772931015ed6c70f9c0ec3bdfaca99ea3 | |
| parent | CodingGuidelines: give an example for case/esac statement (diff) | |
| download | tgif-6a49909b52b48592234da6a53bfe74ea34c302c6.tar.xz | |
CodingGuidelines: give an example for redirection
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | Documentation/CodingGuidelines | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index 169b4358c9..11704fb84c 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -61,6 +61,14 @@ For shell scripts specifically (not exhaustive): redirection target in a variable (as shown above), our code does so because some versions of bash issue a warning without the quotes. + (incorrect) + cat hello > world < universe + echo hello >$world + + (correct) + cat hello >world <universe + echo hello >"$world" + - We prefer $( ... ) for command substitution; unlike ``, it properly nests. It should have been the way Bourne spelled it from day one, but unfortunately isn't. |