diff options
| author |  Jakub Narebski <jnareb@gmail.com> | 2007-01-07 02:52:25 +0100 |
|---|---|---|
| committer |  Junio C Hamano <junkio@cox.net> | 2007-01-06 22:52:54 -0800 |
| commit | 66399eff86555fce52dc7b54829f02e4bb2424b7 (patch) | |
| tree | 2e3340df6121a6d76db1d4191c3238389c92358f | |
| parent | gitweb: Fix error in "rename to"/"copy to" git diff header output (diff) | |
| download | tgif-66399eff86555fce52dc7b54829f02e4bb2424b7.tar.xz | |
gitweb: Fix errors in git_patchset_body for empty patches
We now do not skip over empty patches in git_patchset_body (where
empty means that they consist only of git diff header, and of extended
diff header, for example "pure rename" patch). This means that after
extended diff header there can be next patch (i.e. /^diff /) or end of
patchset, and not necessary patch body (i.e. /^--- /).
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
| -rwxr-xr-x | gitweb/gitweb.perl | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 1b4a4c07b8..7ebdfbbbd5 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -2403,7 +2403,7 @@ sub git_patchset_body { while ($patch_line = <$fd>) { chomp $patch_line; - last EXTENDED_HEADER if ($patch_line =~ m/^--- /); + last EXTENDED_HEADER if ($patch_line =~ m/^--- |^diff /); if ($patch_line =~ m/^index ([0-9a-fA-F]{40})..([0-9a-fA-F]{40})/) { $from_id = $1; @@ -2522,6 +2522,8 @@ sub git_patchset_body { # from-file/to-file diff header $patch_line = $last_patch_line; + last PATCH unless $patch_line; + next PATCH if ($patch_line =~ m/^diff /); #assert($patch_line =~ m/^---/) if DEBUG; if ($from{'href'}) { $patch_line = '--- a/' . |