diff options
| author |  Junio C Hamano <gitster@pobox.com> | 2016-10-17 13:25:18 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-10-17 13:25:18 -0700 |
| commit | 630e05c4f3121aa67dcb1399b62e4c3767d8be55 (patch) | |
| tree | 84c15c832ae77cd76398bf89b35152c08a8a99a8 | |
| parent | Merge branch 'dt/http-empty-auth' (diff) | |
| parent | clone: detect errors in normalize_path_copy (diff) | |
| download | tgif-630e05c4f3121aa67dcb1399b62e4c3767d8be55.tar.xz | |
Merge branch 'jk/clone-copy-alternates-fix'
"git clone" of a local repository can be done at the filesystem
level, but the codepath did not check errors while copying and
adjusting the file that lists alternate object stores.
* jk/clone-copy-alternates-fix:
clone: detect errors in normalize_path_copy
| -rw-r--r-- | builtin/clone.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/builtin/clone.c b/builtin/clone.c index 6c80690adf..6c76a6ed66 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -351,8 +351,11 @@ static void copy_alternates(struct strbuf *src, struct strbuf *dst, continue; } abs_path = mkpathdup("%s/objects/%s", src_repo, line.buf); - normalize_path_copy(abs_path, abs_path); - add_to_alternates_file(abs_path); + if (!normalize_path_copy(abs_path, abs_path)) + add_to_alternates_file(abs_path); + else + warning("skipping invalid relative alternate: %s/%s", + src_repo, line.buf); free(abs_path); } strbuf_release(&line); |