summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Petr Baudis <pasky@ucw.cz>2005-04-17 23:34:51 +0200
committerLibravatar Petr Baudis <xpasky@machine.sinus.cz>2005-05-11 22:45:42 +0200
commit62d046a07b4cd4328d3d40aab097a1d97c4d7b20 (patch)
tree2f922ea7cdc938a75da2747776a6fe056450d332
parent[patch] git: fix overflow in update-cache.c (diff)
downloadtgif-62d046a07b4cd4328d3d40aab097a1d97c4d7b20.tar.xz
Stick a comment to update-cache.c:refresh_cache() that you can't
just free(archive_cache[i]) when replacing it there.
-rw-r--r--update-cache.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/update-cache.c b/update-cache.c
index 3b44fe14ef..19d8f826a5 100644
--- a/update-cache.c
+++ b/update-cache.c
@@ -249,6 +249,9 @@ static int refresh_cache(void)
continue;
}
active_cache_changed = 1;
+ /* You can NOT just free active_cache[i] here, since it
+ * might not be necessarily malloc()ed but can also come
+ * from mmap(). */
active_cache[i] = new;
}
return has_errors;