summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Ramsay Jones <ramsay@ramsayjones.plus.com>2019-02-11 17:16:58 +0000
committerLibravatar Junio C Hamano <gitster@pobox.com>2019-02-11 13:10:57 -0800
commit5fe81438b52f8464947e5b27381a898d7451260e (patch)
tree6c570e2e27e2337d9c45a7ff76253b634f517cce
parentGit 2.18.1 (diff)
downloadtgif-5fe81438b52f8464947e5b27381a898d7451260e.tar.xz
sequencer: make sign_off_header a file local symbol
Commit d0aaa46fd3 ("commit: move empty message checks to libgit", 2017-11-10) removes the last use of 'sign_off_header' outside of the "sequencer.c" source file. Remove the extern declaration from the header file and mark the definition of the symbol with the static keyword. Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--sequencer.c2
-rw-r--r--sequencer.h2
2 files changed, 1 insertions, 3 deletions
diff --git a/sequencer.c b/sequencer.c
index 4034c0461b..d0c2277455 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -31,7 +31,7 @@
#define GIT_REFLOG_ACTION "GIT_REFLOG_ACTION"
-const char sign_off_header[] = "Signed-off-by: ";
+static const char sign_off_header[] = "Signed-off-by: ";
static const char cherry_picked_prefix[] = "(cherry picked from commit ";
GIT_PATH_FUNC(git_path_commit_editmsg, "COMMIT_EDITMSG")
diff --git a/sequencer.h b/sequencer.h
index c5787c6b56..e025deb007 100644
--- a/sequencer.h
+++ b/sequencer.h
@@ -83,8 +83,6 @@ int check_todo_list(void);
int skip_unnecessary_picks(void);
int rearrange_squash(void);
-extern const char sign_off_header[];
-
void append_signoff(struct strbuf *msgbuf, int ignore_footer, unsigned flag);
void append_conflicts_hint(struct strbuf *msgbuf);
int message_is_empty(const struct strbuf *sb,