diff options
| author |  Junio C Hamano <gitster@pobox.com> | 2020-05-08 13:51:21 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-05-08 11:25:12 -0700 |
| commit | 5c7bb0146e1971a00308a667cb0424459262c273 (patch) | |
| tree | 78f16634cd2c90e9361d3592a9b2630bb1577f2a | |
| parent | Git 2.26.2 (diff) | |
| download | tgif-5c7bb0146e1971a00308a667cb0424459262c273.tar.xz | |
CodingGuidelines: do not ==/!= compare with 0 or '\0' or NULL
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | Documentation/CodingGuidelines | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index ed4e443a3c..099968d619 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -238,6 +238,18 @@ For C programs: while( condition ) func (bar+1); + - Do not explicitly compare an integral value with constant 0 or '\0', + or a pointer value with constant NULL. For instance, to validate that + counted array <ptr, cnt> is initialized but has no elements, write: + + if (!ptr || cnt) + BUG("empty array expected"); + + and not: + + if (ptr == NULL || cnt != 0); + BUG("empty array expected"); + - We avoid using braces unnecessarily. I.e. if (bla) { |