summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Paul Mackerras <paulus@samba.org>2008-01-15 22:45:36 +1100
committerLibravatar Paul Mackerras <paulus@samba.org>2008-01-15 22:45:43 +1100
commit5a7f577dcedeff60e5267fd9efbfb05987a359e4 (patch)
treeae38419091d7ee0c095a287e80c63ef87b7c3fe3
parentgitk: Fix bug where editing an existing view would cause an infinite loop (diff)
downloadtgif-5a7f577dcedeff60e5267fd9efbfb05987a359e4.tar.xz
gitk: Fix bug causing Tcl error when no commits are selected
Some of the stuff that commit 31c0eaa8cc10944ebca8aa31fb59f0b77b1b6e77 added to drawvisible isn't appropriate to do when we have no commits, and this was causing a Tcl error if gitk was invoked in such a fashion that no commits were selected. This fixes it by bailing out of drawvisible early if there are no commits displayed. Bug reported by Johannes Sixt. Signed-off-by: Paul Mackerras <paulus@samba.org>
-rwxr-xr-xgitk2
1 files changed, 1 insertions, 1 deletions
diff --git a/gitk b/gitk
index 322ac93f86..c060ce98cb 100755
--- a/gitk
+++ b/gitk
@@ -4573,7 +4573,7 @@ proc drawvisible {} {
set fs [$canv yview]
set ymax [lindex [$canv cget -scrollregion] 3]
- if {$ymax eq {} || $ymax == 0} return
+ if {$ymax eq {} || $ymax == 0 || $numcommits == 0} return
set f0 [lindex $fs 0]
set f1 [lindex $fs 1]
set y0 [expr {int($f0 * $ymax)}]