diff options
| author |  Johannes Schindelin <johannes.schindelin@gmx.de> | 2017-05-04 15:55:38 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2017-05-08 12:18:19 +0900 |
| commit | 5748693b9123f55363211d18e8074db5e1b8384e (patch) | |
| tree | 399bd14bc8d4ac40f8426163ba44e500041f5063 | |
| parent | winansi: avoid buffer overrun (diff) | |
| download | tgif-5748693b9123f55363211d18e8074db5e1b8384e.tar.xz | |
add_commit_patch_id(): avoid allocating memory unnecessarily
It would appear that we allocate (and forget to release) memory if the
patch ID is not even defined.
Reported by the Coverity tool.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | patch-ids.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/patch-ids.c b/patch-ids.c index fa8f11de82..92eba7a059 100644 --- a/patch-ids.c +++ b/patch-ids.c @@ -99,11 +99,12 @@ struct patch_id *has_commit_patch_id(struct commit *commit, struct patch_id *add_commit_patch_id(struct commit *commit, struct patch_ids *ids) { - struct patch_id *key = xcalloc(1, sizeof(*key)); + struct patch_id *key; if (!patch_id_defined(commit)) return NULL; + key = xcalloc(1, sizeof(*key)); if (init_patch_id_entry(key, commit, ids)) { free(key); return NULL; |