diff options
| author |  Junio C Hamano <gitster@pobox.com> | 2014-11-24 09:47:07 -0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-11-24 09:47:07 -0800 |
| commit | 53de742470bdf160a8412d7a2e9c30545db63fac (patch) | |
| tree | 86c03526349868c80b53fd99f914bae7cc63c8fe | |
| parent | SubmittingPatches: refer to t/README for tests (diff) | |
| download | tgif-53de742470bdf160a8412d7a2e9c30545db63fac.tar.xz | |
t/README: justify why "! grep foo" is sufficient
We require use of test_must_fail to check expected non-zero exit by
Git itself, but discourage test_must_fail to be used for checking
exit status of non Git commands that are supplied by the system.
The current text explains the reason for the former but not the
latter.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | t/README | 3 |
1 files changed, 2 insertions, 1 deletions
@@ -335,7 +335,8 @@ Don't: dies in an unexpected way (e.g. segfault). On the other hand, don't use test_must_fail for running regular - platform commands; just use '! cmd'. + platform commands; just use '! cmd'. We are not in the business + of verifying that the world given to us sanely works. - use perl without spelling it as "$PERL_PATH". This is to help our friends on Windows where the platform Perl often adds CR before |