diff options
| author |  Ramkumar Ramachandra <artagnon@gmail.com> | 2013-06-02 19:33:42 +0530 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2013-06-09 15:56:35 -0700 |
| commit | 5269f7f8c6b293f1568c4f03c14596835e22df31 (patch) | |
| tree | 8c211fa92c409a9598e5866afc114d8f72dc5407 | |
| parent | completion: difftool takes both revs and files (diff) | |
| download | tgif-5269f7f8c6b293f1568c4f03c14596835e22df31.tar.xz | |
completion: show can take both revlist and paths
The 'git show' completion uses __git_complete_file (aliased to
__git_complete_revlist_file), because accepts <tree-ish>:<path> as
well as <commit-ish>. But the command also accepts range of commits
in A..B notation, so using __git_complete_revlist_file is more
appropriate.
There still remain two users of __git_complete_file, completions for
"archive" and "ls-tree". As these commands do not take range
notation, and "git show" no longer uses __git_complete_file, the
implementation of it can be updated not to complete ranges, but that
is a separate topic.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | contrib/completion/git-completion.bash | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 1b4b0f95a9..b9dfc3be75 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -2360,7 +2360,7 @@ _git_show () return ;; esac - __git_complete_file + __git_complete_revlist_file } _git_show_branch () |