summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Junio C Hamano <gitster@pobox.com>2016-07-11 10:44:13 -0700
committerLibravatar Junio C Hamano <gitster@pobox.com>2016-07-11 10:44:13 -0700
commit5220b7589b09d62e7166799baa98dcd6a1c02804 (patch)
treea747488ef8d9538f63aea908e73912bb07ef83e2
parentMerge branch 'sb/clone-shallow-passthru' into maint (diff)
parentsh-setup: enclose setting of ${VAR=default} in double-quotes (diff)
downloadtgif-5220b7589b09d62e7166799baa98dcd6a1c02804.tar.xz
Merge branch 'lc/shell-default-value-noexpand' into maint
Fix unnecessarily waste in the idiomatic use of ': ${VAR=default}' to set the default value, without enclosing it in double quotes. * lc/shell-default-value-noexpand: sh-setup: enclose setting of ${VAR=default} in double-quotes
-rw-r--r--git-sh-setup.sh6
1 files changed, 3 insertions, 3 deletions
diff --git a/git-sh-setup.sh b/git-sh-setup.sh
index c48139a494..85db5f1c63 100644
--- a/git-sh-setup.sh
+++ b/git-sh-setup.sh
@@ -160,8 +160,8 @@ git_pager() {
else
GIT_PAGER=cat
fi
- : ${LESS=-FRX}
- : ${LV=-c}
+ : "${LESS=-FRX}"
+ : "${LV=-c}"
export LESS LV
eval "$GIT_PAGER" '"$@"'
@@ -344,7 +344,7 @@ git_dir_init () {
echo >&2 "Unable to determine absolute path of git directory"
exit 1
}
- : ${GIT_OBJECT_DIRECTORY="$(git rev-parse --git-path objects)"}
+ : "${GIT_OBJECT_DIRECTORY="$(git rev-parse --git-path objects)"}"
}
if test -z "$NONGIT_OK"