diff options
author | Junio C Hamano <gitster@pobox.com> | 2021-10-12 13:51:33 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-10-12 13:51:33 -0700 |
commit | 49c2cbe69aa0cb85a2c749ef853eae907d1249ba (patch) | |
tree | 5af8c42e781aed15caed395034e7404535df18fd | |
parent | Merge branch 'jc/prefix-filename-allocates' into maint (diff) | |
parent | setup: use xopen and xdup in sanitize_stdfds (diff) | |
download | tgif-49c2cbe69aa0cb85a2c749ef853eae907d1249ba.tar.xz |
Merge branch 'rs/setup-use-xopen-and-xdup' into maint
Code clean-up.
* rs/setup-use-xopen-and-xdup:
setup: use xopen and xdup in sanitize_stdfds
-rw-r--r-- | setup.c | 8 |
1 files changed, 3 insertions, 5 deletions
@@ -1423,11 +1423,9 @@ const char *resolve_gitdir_gently(const char *suspect, int *return_error_code) /* if any standard file descriptor is missing open it to /dev/null */ void sanitize_stdfds(void) { - int fd = open("/dev/null", O_RDWR, 0); - while (fd != -1 && fd < 2) - fd = dup(fd); - if (fd == -1) - die_errno(_("open /dev/null or dup failed")); + int fd = xopen("/dev/null", O_RDWR); + while (fd < 2) + fd = xdup(fd); if (fd > 2) close(fd); } |